Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #9432 Assign yourself as a commercial when you don't have permission to see all thirds #9578

Merged
merged 3 commits into from Sep 21, 2018

Conversation

fmarcet
Copy link
Contributor

@fmarcet fmarcet commented Sep 20, 2018

Assign yourself as a commercial when you don't have permission to see all thirds

@eldy
Copy link
Member

eldy commented Sep 21, 2018

I d'ont think it is a good way to fix. Because if user has permission to create a thirdparty, he should be able to create a thirdparty T assignig sales representative to himself + another sale representative.
A better fix should be to make something like this:

if user can't "see all thirdparties", the system force the user id to be included into list of sales representative, but the list can still have other sale representatives

@eldy eldy added the PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) label Sep 21, 2018
@fmarcet
Copy link
Contributor Author

fmarcet commented Sep 21, 2018

Hi @eldy , now the sales representative field is always shown. And if the user can't see all thirdparties is assigned by default on list

@eldy eldy merged commit 7a422c9 into Dolibarr:8.0 Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants